Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r214857251 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -33,17 +34,17 @@ public class ServerStats { private static final Logger LOG = LoggerFactory.getLogger(ServerStats.class); - private long packetsSent; - private long packetsReceived; - private long maxLatency; - private long minLatency = Long.MAX_VALUE; - private long totalLatency = 0; - private long count = 0; + private final AtomicLong packetsSent = new AtomicLong(); --- End diff -- I'm not sure if I see what you mean by "being counted"? I've thought that these three metrics should be part of ServerMetrics as: - packetsSent and packetsReceived as SimpleCounter, - requestLatency as AvgMinMaxCounter and should be referred as ServerMetrics.PACKETS_SENT, etc. like the rest. Please let me know if didn't get it right.
---