normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204:
Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254182017
##########
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
##########
@@ -105,6 +116,66 @@ public void testClientResponseStatsUpdate() throws
IOException, InterruptedExcep
assertThat("Last client response size should be greater than 0
after client request was performed",
clientResponseStats.getLastBufferSize(), greaterThan(0));
+
+ byte[] contents = zk.getData("/a", null, null);
+ assertArrayEquals("unexpected data", "test".getBytes(), contents);
+ }
+ }
+
+ @Test
+ public void testServerSideThrottling() throws IOException,
InterruptedException, KeeperException {
+ try (ZooKeeper zk = createClient()) {
+ BufferStats clientResponseStats =
serverFactory.getZooKeeperServer().serverStats().getClientResponseStats();
+ assertThat("Last client response size should be initialized with
INIT_VALUE",
+ clientResponseStats.getLastBufferSize(),
equalTo(BufferStats.INIT_VALUE));
+
+ zk.create("/a", "test".getBytes(), Ids.OPEN_ACL_UNSAFE,
+ CreateMode.PERSISTENT);
+
+ assertThat("Last client response size should be greater than 0
after client request was performed",
+ clientResponseStats.getLastBufferSize(), greaterThan(0));
+
+ for (final ServerCnxn cnxn : serverFactory.cnxns) {
+ final NettyServerCnxn nettyCnxn = ((NettyServerCnxn) cnxn);
+ // Disable receiving data for all open connections ...
+ nettyCnxn.disableRecv();
+ // ... then force a throttled read after 1 second (this puts
the read into queuedBuffer) ...
+ nettyCnxn.getChannel().eventLoop().schedule(new Runnable() {
+ @Override
+ public void run() {
+ nettyCnxn.getChannel().read();
+ }
+ }, 1, TimeUnit.SECONDS);
+
+ // ... and finally disable throttling after 2 seconds.
+ nettyCnxn.getChannel().eventLoop().schedule(new Runnable() {
+ @Override
+ public void run() {
+ nettyCnxn.enableRecv();
+ }
+ }, 2, TimeUnit.SECONDS);
+ }
+
+ byte[] contents = zk.getData("/a", null, null);
+ assertArrayEquals("unexpected data", "test".getBytes(), contents);
+
+ // As above, but don't do the throttled read. Make the request
bytes wait in the socket
+ // input buffer until after throttling is turned off. Need to make
sure both modes work.
+ for (final ServerCnxn cnxn : serverFactory.cnxns) {
+ final NettyServerCnxn nettyCnxn = ((NettyServerCnxn) cnxn);
+ // Disable receiving data for all open connections ...
+ nettyCnxn.disableRecv();
+ // ... then disable throttling after 2 seconds.
+ nettyCnxn.getChannel().eventLoop().schedule(new Runnable() {
+ @Override
+ public void run() {
+ nettyCnxn.enableRecv();
+ }
+ }, 2, TimeUnit.SECONDS);
+ }
+
+ contents = zk.getData("/a", null, null);
+ assertArrayEquals("unexpected data", "test".getBytes(), contents);
Review comment:
nit: `getBytes(Charset)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
