normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204:
Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254181749
##########
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
##########
@@ -105,6 +116,66 @@ public void testClientResponseStatsUpdate() throws
IOException, InterruptedExcep
assertThat("Last client response size should be greater than 0
after client request was performed",
clientResponseStats.getLastBufferSize(), greaterThan(0));
+
+ byte[] contents = zk.getData("/a", null, null);
+ assertArrayEquals("unexpected data", "test".getBytes(), contents);
+ }
+ }
+
+ @Test
+ public void testServerSideThrottling() throws IOException,
InterruptedException, KeeperException {
+ try (ZooKeeper zk = createClient()) {
+ BufferStats clientResponseStats =
serverFactory.getZooKeeperServer().serverStats().getClientResponseStats();
+ assertThat("Last client response size should be initialized with
INIT_VALUE",
+ clientResponseStats.getLastBufferSize(),
equalTo(BufferStats.INIT_VALUE));
+
+ zk.create("/a", "test".getBytes(), Ids.OPEN_ACL_UNSAFE,
Review comment:
nit: `getBytes(Charset)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
