+1 (non-binding) - I built the source code (-Pfull-build) on Ubuntu 20.04 using OpenJDK 8u212 and maven 3.6.3. - all the unit tests passed (both Java and C-client). - I also built and executed unit tests for zkpython - checkstyle and spotbugs passed - apache-rat passed - owasp (CVE check) passed - I executed quick rolling-upgrade tests (using https://github.com/symat/zk-rolling-upgrade-test): - rolling upgrade from 3.5.9 to 3.5.10 - rolling upgrade from 3.5.10 to 3.6.3 - rolling upgrade from 3.5.10 to 3.7.1 - rolling upgrade from 3.7.0 to 3.8.0 - check generated documentation - compared generated release notes ( https://people.apache.org/~symat/zookeeper-3.5.10-rc0/website/releasenotes.html) with Jira ( https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12349434 ) - check the signature and checksum of the artifacts - run some smoke tests using both the binary distribution (apache-zookeeper-3.5.10-bin.tar.gz) and on a freshly compiled version (based on apache-zookeeper-3.5.10.tar.gz)
The C-client tests can be tricky (and annoying) sometimes. On docker some of them fail for me more frequently (also IPV6 tests can be tricky to setup on docker+mac). Also sometimes they leave ZooKeeper processes open after a test failure, and these are preventing later test runs to pass. Worth to take a look and kill these before running the C tests again. In the end I got all of them to pass on Ubuntu 20.04 and gcc 9.4.0 (using native ubuntu, not mac+docker), having all the recommended ubuntu packages installed ( https://github.com/apache/zookeeper/blob/master/README_packaging.md). But would be nice to improve our test quality here... (unfortunately I don't think more recent branches would be in a much better shape) Best regards, Mate On Fri, May 20, 2022 at 12:10 AM Chris Nauroth <cnaur...@apache.org> wrote: > +1 (binding) > > - Verified all checksums. > - Verified all signatures. > - Built from source, including native code on Linux. > - Tests passed. > - Ran several small samples successfully. > > I'm seeing failures in the cppunit tests in zookeeper-client-c. The same > failures reproduce on version 3.5.9 though, so it's not related to this > release. I assume this is a configuration issue I need to diagnose in my > environment. > > Chris Nauroth > > > On Thu, May 19, 2022 at 2:31 AM Szalay-Bekő Máté < > szalay.beko.m...@gmail.com> > wrote: > > > This is a bugfix release candidate for 3.5.10. It fixes 43 issues, > > including CVE fixes, log4j1 removal (by default using reload4j from now) > > and various other bug fixes (thread leaks, data corruption, snapshotting > > and SASL related fixes). > > > > Please note, we announced 3.5 to be EOL from June 1st 2022, so most > likely > > this will be our > > last 3.5 release. > > > > The full release notes is available at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12349434 > > > > *** Please download, test and vote by May 27th 2022, 23:59 UTC+0. *** > > > > > > Source files: > > https://people.apache.org/~symat/zookeeper-3.5.10-rc0/ > > > > Maven staging repo: > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.10/ > > > > The release candidate tag in git to be voted upon: release-3.5.10-rc0 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/zookeeper/KEYS > > > > The staging version of the website is: > > https://people.apache.org/~symat/zookeeper-3.5.10-rc0/website/ > > > > > > Should we release this candidate? > > > > > > Best regards, > > Máté > > >
