Hi there Using `fedpkg retire` the other day, I noticed a bug/feature/glitch. The context is that I have `remote.pushDefault = mjg` in my fedora-specific git config. This is to support an MR based workflow with `mjg` being the name of the git remote pointing at my fork; also, this keeps me from pushing to the main dist-git repo by accident, i.e. from pushing to a remote where I cannot correct mistakes easily.
And it turns out that `fedpkg retire` tries to `git push` and fails in that setup when there is no remote `mjg` being defined (and would push to the wrong repo otherwise). Now, granted, I changed a git setting, so what should I expect? "Expect" hints at the underlying problem here: I did not change any "fedpkg config", nor did I override any fedpkg-generated git config. The `origin` branch still points at the main dist-git repo for that package, not my fork, because I expected things to break if I change the meaning of `origin`. So the bug seems to be that `fedpkg retire` (or, probably, *any* fedpkg command) pushes to an unnamed default repo rather than to `origin` specifically. But really, the main issue is the opaqueness of what fedpkg expects (in terms of git default config, without setting it) and what it does (in terms of git commands plus ?). For the former, `fedpkg clone` could set up a remote named `fedora` or `dist-git` instead of `origin` and push to that specifically. For the latter, I often wonder what `fedpkg foo` does. E.g., is `fedpg retire $REASON` equivalent do ``` git rm -r . echo "$REASON" > dead.package git add dead.package git commit -F dead.package git push ``` (modulo quoting and sanity checks), or does it do more than this (bodhi/koji/whatever)? This could be more transparent in the docs (man). At least it would have helped me pick up the half-finished pieces left behind by the mentioned goof-up. Michael -- _______________________________________________ devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
