Agreed - it was only supposed to run for developer builds

> On Apr 20, 2016, at 7:14 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> 
> wrote:
> 
> I was under the impression that this warning script only ran for developer 
> builds.  But it looks like it's unconditionally run at the end of "make 
> install" (on master only -- so far).
> 
> Should we make this only run for developer builds?  (e.g., check for 
> $srcdir/.git, or somesuch)  I think it's our goal to have zero common 
> symbols, but that may not always be the case, and we don't want this 
> potentially alarming warning showing up for users, right?
> 
> 
>> On Apr 19, 2016, at 11:14 PM, dpchoudh . <dpcho...@gmail.com> wrote:
>> 
>> Thank you very much, Gilles. Declaring globals as static indeed fixed it, 
>> even without initialization (some are complicated structures, so 
>> initializing at declaration is not easy.)
>> 
>> Best regards
>> Durga
>> 
>> 1% of the executables have 99% of CPU privilege!
>> Userspace code! Unite!! Occupy the kernel!!!
>> 
>> On Tue, Apr 19, 2016 at 10:58 PM, Gilles Gouaillardet <gil...@rist.or.jp> 
>> wrote:
>> This is just a warning.
>> 
>> there are some potential issues with uninitialized common symbols, but i 
>> cannot remember the details.
>> 
>> bottom line, they should be avoided :
>> - declare global variables as static if the scope is only one source file
>> - always initialize global variables
>> 
>> Cheers,
>> 
>> Gilles
>> 
>> 
>> On 4/20/2016 11:48 AM, dpchoudh . wrote:
>>> Hello all
>>> 
>>> While doing a 'make install' with some additional code written by me, I get 
>>> the following message:
>>> WARNING!  Common symbols found:
>>> Doing a search on previous mails, I found the following thread that is 
>>> pertinent:
>>> https://www.open-mpi.org/community/lists/devel/2015/04/17220.php
>>> 
>>> However, I could not find out exactly what this warning/error is trying to 
>>> tell me: is there a multiple definition of a global symbol? (that should be 
>>> an error, not a warning, right?)
>>> 
>>> Thanks in advance
>>> Durga
>>> 
>>> 1% of the executables have 99% of CPU privilege!
>>> Userspace code! Unite!! Occupy the kernel!!!
>>> 
>>> 
>>> _______________________________________________
>>> users mailing list
>>> 
>>> us...@open-mpi.org
>>> 
>>> Subscription: 
>>> http://www.open-mpi.org/mailman/listinfo.cgi/users
>>> 
>>> Link to this post: 
>>> http://www.open-mpi.org/community/lists/users/2016/04/28974.php
>> 
>> 
>> _______________________________________________
>> users mailing list
>> us...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
>> Link to this post: 
>> http://www.open-mpi.org/community/lists/users/2016/04/28975.php
>> 
>> _______________________________________________
>> users mailing list
>> us...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
>> Link to this post: 
>> http://www.open-mpi.org/community/lists/users/2016/04/28976.php
> 
> 
> -- 
> Jeff Squyres
> jsquy...@cisco.com
> For corporate legal information go to: 
> http://www.cisco.com/web/about/doing_business/legal/cri/
> 
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: 
> http://www.open-mpi.org/community/lists/devel/2016/04/18790.php

Reply via email to