Dear all Just to clarify, I was doing a build (after adding code to support a new transport) from code pulled from git (a 'git clone') when I came across this warning, so I suppose this would be a 'developer build'.
I know I am not a real MPI developer (I am doing OMPI internal development for the second time in my whole career), but if my vote counts, I'd vote for leaving the warning in. It, in my opinion, encourages good coding practice, that should matter to everyone, not just 'core developers'. However, I agree that the phrasing of the warning is confusing, and adding a URL there to an appropriate page should be enough to prevent future questions like this in the support forum. Thanks Durga 1% of the executables have 99% of CPU privilege! Userspace code! Unite!! Occupy the kernel!!! On Wed, Apr 20, 2016 at 1:41 PM, Ralph Castain <r...@open-mpi.org> wrote: > > > On Apr 20, 2016, at 10:24 AM, Dave Goodell (dgoodell) < > dgood...@cisco.com> wrote: > > > > On Apr 20, 2016, at 9:14 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> > wrote: > >> > >> I was under the impression that this warning script only ran for > developer builds. But it looks like it's unconditionally run at the end of > "make install" (on master only -- so far). > >> > >> Should we make this only run for developer builds? (e.g., check for > $srcdir/.git, or somesuch) I think it's our goal to have zero common > symbols, but that may not always be the case, and we don't want this > potentially alarming warning showing up for users, right? > > > > IMO, this is basically just another warning flag. If you enable most > compiler warnings for non-developer builds, I don't see why you would go > out of your way to disable this particular one. You could always tweak the > output to point to a wiki page that explains what the warning means, so > concerned users can hopefully be assuaged. > > I guess this is where I differ. I see no benefit in warning a user about > something they cannot control and that has no impact on them. These > warnings were intended solely for developers as a reminder/suggestion that > they follow a specific policy regarding common variables. Thus, they convey > nothing of interest or use to a user. > > So I fail to see why we should include this warning in a non-developer > build. As for other warnings, we have a stated policy (and proactive > effort) to always stamp them out, so I don’t think the user is actually > seeing many (or any) of them. Remember, we turn off pedantic and other > levels when doing non-developer builds. > > Seems like this warning falls into the same category to me. > > > > > -Dave > > > > _______________________________________________ > > devel mailing list > > de...@open-mpi.org > > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/04/18794.php > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/04/18795.php
