On Apr 20, 2016, at 9:14 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote: > > I was under the impression that this warning script only ran for developer > builds. But it looks like it's unconditionally run at the end of "make > install" (on master only -- so far). > > Should we make this only run for developer builds? (e.g., check for > $srcdir/.git, or somesuch) I think it's our goal to have zero common > symbols, but that may not always be the case, and we don't want this > potentially alarming warning showing up for users, right?
IMO, this is basically just another warning flag. If you enable most compiler warnings for non-developer builds, I don't see why you would go out of your way to disable this particular one. You could always tweak the output to point to a wiki page that explains what the warning means, so concerned users can hopefully be assuaged. -Dave
