I also think this symbol checker should not be in the tarball. Howard
2016-04-20 13:08 GMT-06:00 Jeff Squyres (jsquyres) <jsquy...@cisco.com>: > On Apr 20, 2016, at 2:08 PM, dpchoudh . <dpcho...@gmail.com> wrote: > > > > Just to clarify, I was doing a build (after adding code to support a new > transport) from code pulled from git (a 'git clone') when I came across > this warning, so I suppose this would be a 'developer build'. > > No worries. I only brought it up because this is currently on master (and > not v2.x), but it will eventually end up in a release branch -- even if > it's v3.0.0. So it's something we'd want figure out before it hits the > release branch. > > > I know I am not a real MPI developer (I am doing OMPI internal > development for the second time in my whole career), but if my vote counts, > I'd vote for leaving the warning in. > > I don't know why you keep pretending that you're not an OMPI developer. > :-) > > You're developing a BTL and asking all kinds of good questions about the > code, and that's good enough for all of us. > > > It, in my opinion, encourages good coding practice, that should matter > to everyone, not just 'core developers'. However, I agree that the phrasing > of the warning is confusing, and adding a URL there to an appropriate page > should be enough to prevent future questions like this in the support forum. > > FWIW: I think I agree with Ralph on this one. Yes, we should make those > common symbols zero. But a user seeing this warning will likely be > concerned, and there's nothing they can do about it. So I think it should > be a "developer only" kind of warning. > > My $0.02. > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/04/18797.php >
