On Wed, 5 Mar 2003, Keith Packard wrote:
>
> Around 23 o'clock on Mar 5, Mark Vojkovich wrote:
>
> > Offscreen pixmaps don't so this has been broken since 3.9.x.
> > It's obviously not a common case if I'm just seeing this now for
> > the first time.
>
> The core cursors are all 16x16, which is presumably smaller than the pixmap
> code would put in off-screen memory for cards that didn't have hardware
> cursor support. Still, it's a bit surprising that no-one has ever seen a
> problem with this (or at least no-one has complained here).
>
> > OK, I'll change them then. I suppose the miTranslate check should
> > go in miDCPutBits. Do you think I should bother with miTranslate checks
> > in the shadow framebuffer layers?
>
> Yes, miDCPutBits should check miTranslate. The shadow layers *mustn't*
> be changed -- the miTranslate checks would have occured in whatever
> function was calling through the shadow layer:
>
> miPolyArc
> shadowPushPixels
> fbPushPixels
>
> The miTranslate check is done in miPolyArc before shadowPushPixels is
> called. If this were broken, lots of stuff wouldn't work on shadow frame
> buffers.
You don't understand. The shadow framebuffer SetSpans, FillSpans
and PushPixels ARE CURRENTLY TRANSLATING. They shouldn't because,
as you say, they are already translated by the time they get them.
I think they never actually get used which is why you don't see
more stuff broken. In your above example, for instance, they computed
the bounding box in PolyArc and unwrapped - PushPixels in the
shadow layer never got called.
Mark.
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel
