> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On > Behalf Of Donald Carr > Sent: Thursday, December 13, 2012 10:16 PM > To: Jenssen Tim > Cc: [email protected]; Cristian Tibirna > Subject: Re: [Development] [Qt-creator] gerrit-speak > > +1 > > I have seen some people take serious issue with the phrasing; the iOS > contributions spring to mind, but many people clearly feel publicly disgraced.
Oh well, if you already feel offended by this phrasing, I guess you should get a thicker skin ... we've people from very different cultures and with varying English language skills in the community, so you should just take things with a pinch of salt in general. Anyway, the sentence is from the upstream gerrit project, and it actually describes pretty good what it means, technically: "you shouldn't submit this" - I don't think this is ready to go in as it is. "I would prefer" - ..but at the same time this isn't a veto, so if another approver thinks differently (with reasons), please go ahead. If anyone things there are better ways to formulate exactly this, I suggest bringing it up in the gerrit forums. There's a point though that a lot of people (including me) are using -1 for 'this requires more work', and -2 for 'the patch, or target branch is just wrong, please abandon'. So if the intention of the patch is fine in general, but contains some errors, I myself tend to give -1, though it should maybe be a -2. Anyway, I think everyone giving a -1 or -2 should put an explanation in the comments which explains things, so I haven't yet perceived this as a real issue. Regards Kai > On Dec 13, 2012 12:51 PM, "Jenssen Tim" <[email protected]> wrote: > > > ________________________________________ > Von: [email protected] [qt- > [email protected]]" im Auftrag > von "Cristian Tibirna [[email protected]] > Gesendet: Donnerstag, 13. Dezember 2012 18:15 > An: [email protected] > Betreff: [Qt-creator] gerrit-speak > > > (Rethoric: should this go to a more generic qt list?) > > > > Hello > > > > (First a side question, is there a more consequent documentation > about the use > > of gerrit?) > > > > Is it only me that finds the "-1" review default message in gerrit > rather > > irritating? > > > > "I would prefer that you didn't submit this" > > > > reads to my brain much like "go f*k yourself" without the raw > words. > > > > I get all the idea of the automating thing and all, and that > machines have no > > emotion, but, if I don't miss something obvious (this happens to > me though...) > > and if that message is configurable, how about > > > > "This requires more work" > > > > instead? > > +1 > Yes this describes more the workflow how I use that with my > colleges. > _______________________________________________ > Development mailing list > [email protected] > http://lists.qt-project.org/mailman/listinfo/development > _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
