14.12.2012, 15:02, "Sergio Ahumada" <[email protected]>: > On 12/14/2012 11:54 AM, Bache-Wiig Jens wrote: > >>> Oh well, if you already feel offended by this phrasing, I guess you >>> should get a thicker skin ... we've people from very different >>> cultures and with varying English language skills in the community, so >>> you should just take things with a pinch of salt in general. >>> >>> Anyway, the sentence is from the upstream gerrit project, and it >>> actually describes pretty good what it means, technically: >>> >>> "you shouldn't submit this" - I don't think this is ready to go in as >>> it is. >>> "I would prefer" - ..but at the same time this isn't a veto, so if >>> another approver thinks differently (with reasons), please go ahead. >> Actually looking at the android version of gerrit which I presume would >> be using the upstream version they have omitted the comments entirely, >> merely using a "Code-Review +1" comment. >> They also have a helpful "browse projects" link in the header and their >> CSS looks cleaner. Perhaps we are simply not up to date or we actually >> applied those comments locally? >> >> See https://android-review.googlesource.com/#/q/status:open,n,z >> >> Jens > > That's 2.5 version and we based ours in 2.2.1 > > Some attempts to go for 2.2.2 have been made without much success > https://bugreports.qt-project.org/browse/QTQAINFRA-466 > > They just change the implementation between minor releases. > Also, it seems like they don't want our features to be up-streamed, see > https://groups.google.com/forum/?fromgroups=#!topic/repo-discuss/gXjbuhfW0tg > for the topic feature discussion, so it' even harder to be in sync.
Well, Gerrit 2.4 introduced user-defined submit rules, and Gerrit 2.5 introduced plugins. I think it should be possible to implement everything needed on top of these features now. -- Regards, Konstantin _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
