My seednode came online right before 1462 was released and was seeding. Since 1462 I have not seen a single seed client connect. My logs are full of:
Jun 02, 2014 02:22:12:164 (freenet.support.SerialExecutor$2, FNP incoming auth packet handler thread(0), ERROR): Caught java.lang.NullPointerException java.lang.NullPointerException at freenet.node.PeerNode.userToString(PeerNode.java:3819) at freenet.node.PeerNode.<init>(PeerNode.java:624) at freenet.node.SeedClientPeerNode.<init>(SeedClientPeerNode.java:20) at freenet.node.FNPPacketMangler.getPeerNodeFromUnknownInitiator(FNPPacketMangler.java:1493) at freenet.node.FNPPacketMangler.processJFKMessage3(FNPPacketMangler.java:1369) at freenet.node.FNPPacketMangler.access$200(FNPPacketMangler.java:75) at freenet.node.FNPPacketMangler$2.run(FNPPacketMangler.java:567) at freenet.support.SerialExecutor$2.run(SerialExecutor.java:73) at freenet.support.PooledExecutor$MyThread.innerRun(PooledExecutor.java:248) at freenet.support.PooledExecutor$MyThread.realRun(PooledExecutor.java:188) at freenet.support.io.NativeThread.run(NativeThread.java:129) https://github.com/freenet/fred-staging/commit/6d0321c1bbf96c593681719c8d4d0a63555d2e32 was getting rid of string concatenations, but looks like it did more than that. src/freenet/node/PeerNode.java @@ -3816,7 +3816,7 @@ public int selectNegType(OutgoingPacketMangler mangler) { } public String userToString() { - return "" + getPeer(); + return getPeer().toString(); } public void setTimeDelta(long delta) { are NOT functionally equivalent. -- I may disagree with what you have to say, but I shall defend, to the death, your right to say it. - Voltaire Those who would give up Liberty, to purchase temporary Safety, deserve neither Liberty nor Safety. - Ben Franklin _______________________________________________ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl