On Mon, Jan 14, 2002 at 11:06:56AM -0500, Tavin Cole wrote: > On Mon, Jan 14, 2002 at 04:42:52PM +0100, Oskar Sandberg wrote: < > > > I think the levels are good if somewhat mislabeled. Remaning > > > > ERROR -> CRITICAL > > NORMAL -> IMPORTANT > > MINOR -> RELEVANT > > DEBUG -> TYPICAL > > > > so they clearly mark the importance of the statement would probably help > > us use them correctly. > > The differentiation b/t MINOR and DEBUG (or RELEVANT and TYPICAL) has > always seemed pretty arbitrary to me. If you don't buy my two-level > logging how about three?
As I have tried to use it: ERROR (CRITICAL) = A situation that indicates that the node is broken and cannot continue functioning. NORMAL (IMPORTANT) = A situation that indicates that the node is not behaving as it should. MINOR (RELEVANT) = A situation that in itself is not an error, but that may indicate a problem if it occurs all the time. Any error that may be the fault of another party (bad data, broken connections, no response to messages, etc) falls here or below. DEBUG (TYPICAL) = Any statement that occurs predictably even under ideal circumstances. There are a couple of exceptions (I moved one of the "message received" logs into MINOR because people wanted it) but those are my guidlines. > > I think what is important is that log statements never occur within > > internal loops. > > Fred is no more than a collection of internal loops ;) I don't remember the formal defenitions of these things, but by "internal loop" I meant one that continues without interaction from outside the program (user input, network traffic, system clock, etc). -- Oskar Sandberg oskar at freenetproject.org _______________________________________________ Devl mailing list Devl at freenetproject.org http://lists.freenetproject.org/mailman/listinfo/devl
