On Sun, Feb 04, 2007 at 10:46:15PM +0100, bbackde at googlemail.com wrote: > On 2/4/07, Jerome Flesch <jflesch at nerim.net> wrote: > > > If FCP2 want to provide clients an easy access, then the following > > > changes are needed: > > > > > > Answer to a ModifyPersistentRequest should not be a new > > > Persistent<blah> with all values, but a ModifiedPersistentRequest > > > message with only the changed values. Otherwise the client has to do > > > all syncing and searching for really changed values. > > > > > > Answer to a RemovePersistentRequest should be a > > > RemovedPersistentRequest, this is a clear answer to the request and > > > clients don't need to do much investigation here. > > > > > Does that mean you will remove the GetFailed message ? > > Don't forget that currently, this message is broadcasted to all the > > FCP clients with WatchGlobal set to 1 (Thaw, for example). > > > Of course GetFailed will not be removed, but it would not be sent on a > RemovePersistentRequest. And it was never sent before after a > RemovePersistentRequest (was not implemented in node), so nothing > would change.
It was certainly intended that it be sent. In practice, if you send a RemovePersistentRequest this will cause the request to be cancelled, which will then cause it to produce a GetFailed with reason=Cancelled. The only problem with the current behaviour is that there is no indication as to whether the request is still in the queue. We can fix that by including an explicit indicator - a flag. > > > > > Its easy to implement this in the node and I offer to do the changes > > > and to document them in the wiki. Existing clients are not affected. > > > > > > Please discuss this, and with your answer provide an explanation WHY > > > you recommendation is better then the given ones, thanks. > > > > > > rgds, bback. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20070205/3f8ffdd1/attachment.pgp>
