On 2/5/07, Matthew Toseland <toad at amphibian.dyndns.org> wrote: > On Sun, Feb 04, 2007 at 09:38:47PM +0100, bbackde at googlemail.com wrote: > > If FCP2 want to provide clients an easy access, then the following > > changes are needed: > > > > Answer to a ModifyPersistentRequest should not be a new > > Persistent<blah> with all values, but a ModifiedPersistentRequest > > message with only the changed values. Otherwise the client has to do > > all syncing and searching for really changed values. > > I don't get this. Why not just have a Persistent<blah> ? Surely less > messages is the simpler solution?
It makes the processing for clients easier. And I think this should be the goal. Consider the code of a client: the client gets a new PersistentBlah message, and if he already have the request in its table/list, then he now have to compare all values (knowing which ones could change) against the new values. A ModifiedPersistentRequest message would contain only the changed values, making life for clients easier. Also its more simple for clients to get a concrete answer to a request, not a common answer like a PersistentBlah. This is just my point of view, as client developer ;) feel free to vote me down. > > > > Answer to a RemovePersistentRequest should be a > > RemovedPersistentRequest, this is a clear answer to the request and > > clients don't need to do much investigation here. > > Or a GetFailed with Removed=true. See above. Of course the client could figure out what happened with a flag but its easier with an own message. > > > > Its easy to implement this in the node and I offer to do the changes > > and to document them in the wiki. Existing clients are not affected. > > By all means. > > > > Please discuss this, and with your answer provide an explanation WHY > > you recommendation is better then the given ones, thanks. > > > > rgds, bback. > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFFxyExA9rUluQ9pFARAhHgAJ9tha5al/ze6VRgMwoMH+sUW+KkqgCZAaQd > 70Hj0vKr491RTTnuJROEoEc= > =7v5n > -----END PGP SIGNATURE----- > > > _______________________________________________ > Devl mailing list > Devl at freenetproject.org > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl > >
