Hi Guillaume, > On 10 Oct 2016, at 16:43, Guillaume Delhumeau <[email protected]> > wrote: > > Hello. > > In Flamingo, we have a variable called $displayPageHeader, defined in > layoutvars.vm. > > When it is set, the logo is not displayed in the top menu, but on a header > under it. It is used by some clients, where they could also add some extra > content.
hmmm… I’m wondering if this is the best way. We already a UIXP for page header so if some users want a custom header they can already do so. I don’t think it belongs to the theme. So instead I would have a boolean to decide whether to display the logo or not. Actually even that boolean could be avoided by deciding that if the logo field is empty then no logo is displayed. Am I missing something? Thanks -Vincent > Example: > http://tof.canardpc.com/view/83040d2d-79c4-4f1b-ab1b-af8ee5f3be62.jpg > > I'd like to expose this variable into the Flamingo Theme, see: > http://jira.xwiki.org/secure/attachment/33074/33074_preview.png > > However, in order to enable the live preview in the theme editor, I need to > be able to change the value of the $displayPageHeader variable on the fly, > or at least by setting a parameter in the query string. > > This variable will be: > displayPageHeader > > Possible values: > "true", "false" > > Default value: > Fallback to the Flamingo Theme, "false" if empty. > > I don't have other use-case to cover with this variable. > > Here is my +1. > > Thanks, > > -- > Guillaume Delhumeau ([email protected]) _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
