On Thu, Mar 19, 2009 at 2:18 PM, Bob Thomas <[email protected]> wrote: > So, if the template tag wasn't hard enough to write, it's not helpful?
Um. That's not what I read from what Luke's saying. > I'm not sure how I missed the tests, though. I think I was just > looking at the regression tests for the built-in tags/filters. I'll > add tests to my patch, but only if it would be helpful. It's not > really clear if you even want help, or you would rather I just stop > wasting your time so you can write it yourself. Again, that's not at all what I get from Luke's message. I don't quite understand your hostile tone here; Luke's telling you what needs to happen with your patch before it can be checked in. This is how code review works: other people look at your code and give you feedback. That's what Luke's doing here. In this case, tests are not just "useful", they're *required* -- our policy (detailed at length at http://docs.djangoproject.com/en/dev/internals/contributing/#patch-style) is that tests and documentation are required: """ * The code required to fix a problem or add a feature is an essential part of a patch, but it is not the only part. A good patch should also include a regression test to validate the behavior that has been fixed (and prevent the problem from arising again). * If the code associated with a patch adds a new feature, or modifies behavior of an existing feature, the patch should also contain documentation. """ In many -- even most -- cases, the tests and docs are the hard parts of the patch. I can't tell you how many easy fixes I've committed that required 10 or 100 times as many lines of tests as code. This is even more vital when we're dealing with security issues. Security features are worthless if they don't work. I'm sorry if you perceived Luke's feedback as a personal slight, but that's not what's happening here. Jacob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
