I would write the tests though I'm not 100% sure how to write regression tests for a UI change... any suggestions on how to go about doing that?
On Thu, Sep 17, 2009 at 2:04 PM, Joshua Russo <josh.r.ru...@gmail.com>wrote: > I don't have any say in what gets accepted or not but I do believe that > your solution is a decent one. I'm continuing with mine because it addresses > a current need simply and can be (fairly) easily tested. If you can create > the regression tests for yours then I believe you might get more traction. > Then again there may be some hesitation to the level of complexity you are > introducing. There is always a strong inclination in the the project for > simplicity. > > > On Thu, Sep 17, 2009 at 5:42 PM, Ben Davis <bendavi...@gmail.com> wrote: > >> I'm not sure if anyone's seen this, but I've written a patch for >> multi-sort columns in the changelist ui here: >> >> http://code.djangoproject.com/ticket/11868 >> >> Not sure if this is what you guys had in mind, but I'd be interested in >> your feedback. >> >> >> On Thu, Sep 17, 2009 at 12:57 PM, Joshua Russo <josh.r.ru...@gmail.com>wrote: >> >>> >>> Sorry for dragging this back out of the depths but I was reviewing my >>> code for regression testing and I noticed I had missed this comment >>> way back when. >>> >>> Where is this named sort option documented? >>> >>> It seems to me that the implementation that I have here would still be >>> useful even if you could associate multiple sort columns with a single >>> displayed column. I think that it's confusing to the developer not to >>> have the list display using the sort order that is defined within the >>> model. >>> >>> >>> On Aug 13, 2:49 pm, Rock <r...@rockhoward.com> wrote: >>> > My suggestion for handling the UI for multi-column sorts is to allow >>> > the definition >>> > of named sorts in a manner similar to the way that the default sorting >>> > is defined. >>> > With this in place, additional multi column orders can be accomplished >>> > simply >>> > by using this name as a sort selection and applying the corresponding >>> > named sort. >>> > >>> > If this is an acceptable approach, I can flesh out the API for it. >>> > >>> > On Aug 11, 10:10 pm, Malcolm Tredinnick <malc...@pointy-stick.com> >>> > wrote: >>> > >>> > >>> > >>> > > For those, like me, wondering what this proposal was about, it's >>> > > concerning changing sorting in the admin interface to initially use >>> the >>> > > full set of fields specified in Meta.ordering on the model. >>> > >>> > > What I can't work out yet, due to difficulty in reviewing the patch, >>> > > mentioned below, is whether it allow sorting by more than one column >>> via >>> > > the column-clicking method. That would almost certainly seem to be a >>> > > request that is going to arrive 10 seconds after a feature like this >>> is >>> > > committed, although the difficulty has always been with how the UI >>> works >>> > > for that situation. >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
