On Oct 10, 12:55 pm, Luke Plant <l.plant...@cantab.net> wrote:
> > master: 314.442s
> > logging: 317.096s
>
> > Since there's nothing at all in my logging code that will speed
> > anything up, I'm putting that down to chance (I did run the suite a
> > few times first to "warm up" the VM I used, but like I said, this
> >  is pretty much the opposite of science).
>
> Those numbers are the time in seconds, right? In which case your
> branch is slower, not faster, as I think you are implying.  It could
> still be down to chance, but its only 1% which would be an acceptable
> hit for me anyway.

Oops, yes you're right - I misread the numbers. A 2.5 second different
would correspond to around 350,000 log messages (assuming the rate of
130,000/second from my microbenchmark) - I have no idea how many
statements the unit tests execute in total. Once I've written a bit
more code of course I could always find out using a logger...

Cheers,

Simon
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to