The only concern in that ticket seems to be that 0 means different things for different cache backends.
There may have been some effort towards making them all behave the same when 0 is passed. Personally I prefer the approach of not messing with the value at all, and passing it straight to the configured cache backend. You don't want Django messing with your .extra() or .raw(), so why should it try to magically alter the parameters you pass to your cache backend? Furthermore, correct me if I'm wrong, but: timeout = timeout or self.default_timeout seems like an oversight on the part of whoever wrote that line originally, not some intended functionality to prevent 0 from ever making it to the actual backend. Chances are, if you configured a cache backend for your Django project, you chose one explicitly and have some cognition of how it works. We could could change line this to: timeout = timeout is not None and timeout or self.default_timeout and simply add a big fat warning to the docs stating that 0 means different things on different backends. Thoughts? Tobias On Thu, Jul 22, 2010 at 7:44 AM, Will Hardy <e.willha...@gmail.com> wrote: > I thought this was familiar too: < > http://code.djangoproject.com/ticket/6988> > > Is this the ticket you were thinking of? It seems to have been reopened. > > Cheers, > > Will Hardy > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-develop...@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com<django-developers%2bunsubscr...@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- Tobias McNulty Caktus Consulting Group, LLC P.O. Box 1454 Carrboro, NC 27510 USA: +1 (919) 951-0052 http://www.caktusgroup.com -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
