On Fri, Jul 23, 2010 at 8:17 AM, Tobias McNulty <tob...@caktusgroup.com> wrote: > The only concern in that ticket seems to be that 0 means different things > for different cache backends. > There may have been some effort towards making them all behave the same when > 0 is passed. > Personally I prefer the approach of not messing with the value at all, and > passing it straight to the configured cache backend. You don't want Django > messing with your .extra() or .raw(), so why should it try to magically > alter the parameters you pass to your cache backend?
I agree. > Furthermore, correct me if I'm wrong, but: > timeout = timeout or self.default_timeout > seems like an oversight on the part of whoever wrote that line originally, I think that "whoever" was me, and I think you're right that it should have been more like `timeout = self.default_timeout if timeout is None else timeout` (or the equivalent 2.4 syntax). I'd bless a patch making that simple fix. It's very slightly backwards compatible, but almost certainly in a good way, so I'm fine with the change. Jacob -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
