-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Mmm, this reads to me like a bit of a mis-understanding. Hinges on what Jonas means by "before the patch gets accepted." The phrase is slightly confusing because we have an Accepted state in Trac, but that applies to tickets, in concept, not to specific patches.
Declining to do additional patch work before the _ticket_ is marked Accepted is reasonable and consistent with our usual process. Marking the ticket accepted only means that the general idea is accepted in principle, it does not validate the specific approach in any existing patch. Docs and tests are, of course, required before any patch is actually committed. In my reading of this thread, I think that's already understood. Aymeric mentioned that tests and/or docs would clarify the intent of some of the tickets, which isn't clear enough for him to even accept or decline the ticket in concept. In that case, I think it would make sense to close the ticket "needsinfo" with specific comments on what about the feature request is not clear enough to evaluate. (Patch review shouldn't even be necessary in order to move a ticket from Unreviewed to Accepted or closed, IMO - the ticket description itself ought to provide clear enough motivation for that). Carl -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7hRg8ACgkQ8W4rlRKtE2flDACdFPDijhay53JXoFHAIobjFCRP 0FwAoI81yprWk359Tzb3XQKSsEng8P+a =4YyI -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
