On Fri, Sep 20, 2013 at 4:13 PM, Florian Apolloner <[email protected]> wrote: >> It seems more sensible to hook something that has the lifetime of the >> request to the request, rather than stick it in TLS, keyed to the >> thread serving the request. > > > Jupp, sadly I don't see a sensible way around thread local storage here :( >
All good points, I just have this mental "HMM" when I see TLS as the solution for anything. TLS is already used for things like the language code of the current request, which avoids you having to pass around a state object or passing down lang_code all down the stack, but means that things like URL reversing and resolving benchmarks are slow (O(n²)) with USE_I18N on. The problem with tying everything to the request is that you end up with code that only works with requests or request-like-objects. The problem with not tying everything to the request is that things get slower. :( Cheers Tom -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
