"Force" or "nudge" to upgrade pip? i.e. should Django not install with pip < some version? That seems controversial.
Is the "man-page of pycompile you can exclude certain packages" suggestion some change we should make in Django? As long as we have some solution to avoid support queries about this problem, I don't care which one we choose. On Saturday, November 28, 2015 at 12:52:56 PM UTC-5, Florian Apolloner wrote: > > If I am not mistaken 1.5.6 is still one of those versions which whould > install from external sources etc… So from a security point of view I wanna > force people to upgrade. > > Regarding purity: No it is not purity, as the PR already showed, at least > project_template would be missing etc… Also this is not a problem of Django > but rather packaging in distribution, ie affects more packages to Django. > So why add a specialcased solution in Django if we maybe should fix > packaging instead? > > On Saturday, November 28, 2015 at 5:03:12 PM UTC+1, Tim Graham wrote: >> >> Claude said, "I also encountered this error when using pip 1.5.6 (default >> version in Debian stable)." I guess at least some people might not want to >> upgrade system packages. >> >> Is your main opposition to the change a "purity" one? Sure, we could add >> a pip version check, but I don't see any downside to the proposed change. >> >> On Saturday, November 28, 2015 at 10:53:54 AM UTC-5, Florian Apolloner >> wrote: >>> >>> I rather add a check to setup.py and tell people to upgrade pip >>> >>> On Saturday, November 28, 2015 at 1:46:48 PM UTC+1, Tim Graham wrote: >>>> >>>> I believe this is a new issue in 1.9, not 1.8 as the subject says, >>>> correct? >>>> >>>> I wouldn't mind seeing it fixed as old versions of pip report a >>>> SyntaxError when installing Django (this doesn't affect the install, but >>>> creates confusion for users and resulted in at least two bug reports like >>>> https://code.djangoproject.com/ticket/25584). >>>> >>>> On Saturday, November 28, 2015 at 6:38:00 AM UTC-5, Florian Apolloner >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Those packages/modules are clearly marked as package data ( >>>>> https://github.com/django/django/blob/master/setup.py#L26-L28), so >>>>> imo it is a bug in Debian packaging (although I do understand that it >>>>> might >>>>> not be the easiest to fix…). According to the man-page of pycompile you >>>>> can >>>>> exclude certain packages, this is imo the way to go. >>>>> >>>>> Cheers, >>>>> Florian >>>>> >>>>> P.S.: Also you seem to miss the project_template in your PR. >>>>> >>>>> On Saturday, November 28, 2015 at 12:26:27 PM UTC+1, lamby wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I sent this first as a pull request — talk is cheap, code is better, >>>>>> etc. — but now feel I should I have posted here first. >>>>>> >>>>>> The underlying issue is that Debian packages unconditionally >>>>>> byte-compile .py files under dist-packages upon installation using >>>>>> `pycompile` and do not silence errors by design. Thus the "invalid" >>>>>> files that form part of the `startapp` template require tedious >>>>>> special >>>>>> attention to avoid errors. >>>>>> >>>>>> I'm sure this would affect other, non-Debian, packaging systems, as >>>>>> well >>>>>> as surface weird behaviour elsewhere. Shipping broken .py files >>>>>> masquerading as valid ones additionally just feels dirty. >>>>>> >>>>>> We templated .py files before, but as the '{{ foo }}' bits were >>>>>> inside >>>>>> strings, docstrings or comments, the pre-rendered templates were >>>>>> perfectly valid Python. >>>>>> >>>>>> Therefore I think need a way of shipping the "invalid" .py files that >>>>>> form part of the `startapp` template without .py extensions but, of >>>>>> course, ensuring they end up as .py after rendering. (Or we use some >>>>>> entirely different mechanism.) >>>>>> >>>>>> My current implementation is >>>>>> <https://github.com/django/django/pull/5735>; see some additional >>>>>> comments I made there. >>>>>> >>>>>> >>>>>> Regards, >>>>>> >>>>>> -- >>>>>> Chris Lamb >>>>>> chris-lamb.co.uk / @lolamby >>>>>> >>>>> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0ac2d962-95f9-491a-8b8b-e37646109d61%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
