> On Jan 8, 2016, at 12:53 PM, Carl Meyer <c...@oddbird.net> wrote: > > On 01/08/2016 11:48 AM, Ryan Hiebert wrote: >> >> While class-based middleware factories couldn't just do the same thing >> in the __init__ method, they could do that in a __new__ method instead, >> and then we could make returning the ``get_response`` function the >> "one way to do it." > > I'd be more sympathetic to this viewpoint if Django hadn't already had > the `MiddlewareNotUsed` exception for many years in this very role. > There's no reason to break it if we don't absolutely have to. And since > we've got it, and it works in any scenario, it may as well be the > preferred method. > > [snip] > > That said, I expect plenty of people (probably myself included) to use > the "just return ``get_response``" trick, whether it's documented or > not, and I think that's totally fine. > Your reasoning makes sense. I'll probably be one of those that will prefer the return ``get_response`` trick, even in classed based middlewares.
-- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/1A12E94D-9D03-4C6B-8771-A22F00903C8E%40ryanhiebert.com. For more options, visit https://groups.google.com/d/optout.
