On 01/11/2016 04:52 PM, Shai Berger wrote: > On Monday 11 January 2016 01:54:58 Raphaël Barrois wrote: >> I've got only one minor suggestion to the "backwards compatibility" >> section of the DEP. >> >>> It currently states that "If the ``MIDDLEWARE`` setting is provided >>> [...], the old ``MIDDLEWARE_CLASSES`` setting will be ignored. >> >> I suggest that, instead, this fails loudly if both ``MIDDLEWARE`` and >> ``MIDDLEWARE_CLASSES`` are set. >> This would prevent projects from keeping the two versions around and >> having to remember which one is currently in use. >> > > If the failure is too loud, it makes it hard to use the same settings file > for > testing with multiple versions of Django -- a practice used by Django itself, > and I think also by some reusable apps. We've run into this issue with the > change of the database test settings.
Yes; I think a checks-framework warning (like what we do for `TEMPLATE_*` vs `TEMPLATES`) is the appropriate level; likely to catch an unintentional usage, but silence-able if the duplication is intentional. Carl -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/569D7B30.2020109%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
