On 01/10/2016 04:54 PM, Raphaël Barrois wrote: > I've got only one minor suggestion to the "backwards compatibility" > section of the DEP. > >> It currently states that "If the ``MIDDLEWARE`` setting is provided >> [...], the old ``MIDDLEWARE_CLASSES`` setting will be ignored. > > I suggest that, instead, this fails loudly if both ``MIDDLEWARE`` and > ``MIDDLEWARE_CLASSES`` are set. > This would prevent projects from keeping the two versions around and > having to remember which one is currently in use.
Yes, that's a good idea. I think I had vaguely in mind that this wasn't possible because the global default for MIDDLEWARE_CLASSES is non-empty, but I guess we can still check to see whether the actual value != the global default. > Beyond that, I love the overall design of this upgrade :) Great! Carl -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/5693EE27.5000209%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
