To be clear, the recommended git style is not present tense, it is imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the frobnicator", it should be "Fix #12345 -- Regulate the frobnicator."
Carl On 06/24/2016 11:45 AM, Tobias McNulty wrote: > I'm in support of this as well. Is the suggestion to change the format to: > > A) Fixes #12345 -- Add support for ... / Validate that .... / etc. > > OR > > B) Fixes #12345 -- Adds support for ... / Validates that ... / etc. > > OR > > C) Something else? > > I assume (A) but others may interpret this differently? > > On Fri, Jun 24, 2016 at 1:25 PM, Markus Holtermann > <i...@markusholtermann.eu <mailto:i...@markusholtermann.eu>> wrote: > > I don't mind either way. If everybody seems to use present tense these > days, yeah, let's do that as well. As long as the general style of the > commit messages stays: Fixes|Refs #12345 -- Make it work > > My 2ยข > > /Markus > > > On Fri, Jun 24, 2016 at 11:04:39AM -0600, Jacob Kaplan-Moss wrote: > > I'm not entirely sure because my memory sucks, but odds are that > I started > the current standard of using past-tense. > > FWIW I no longer care even at all, I think as long as commit > messages are > clear we I don't care what tense they are. Following the > standard git way > seems totally OK to me. > > Jacob > > On Fri, Jun 24, 2016 at 10:59 AM, Carl Meyer <c...@oddbird.net > <mailto:c...@oddbird.net>> wrote: > > On 06/24/2016 10:55 AM, Tim Graham wrote: > > A few contributors indicated in #django-dev that it could > be beneficial > > to change our commit message format to match git's > guidelines of present > > tense (instead of our current past tense convention) as it > would be one > > less thing to remember when contributing to Django. > Besides consistency > > with the current history, do you feel there are any > benefits in > > continuing to use past tense instead of present tense? > > I was one of those contributors in #django-dev. Not only are > past-tense > commit messages non-standard for git (meaning they are one > more thing a > new contributor is likely to trip over), I also personally > find them > harder to write and make clear. Sometimes in a commit > message you need > to reference past (pre-commit) behavior and make it clear > how the commit > changes that behavior. I occasionally find that harder to do > clearly > when the entire commit message is supposed to worded in the > past tense. > > So I find all the advantages (except for consistency with > past history) > in favor of switching to the imperative mood. > > Carl > > -- > You received this message because you are subscribed to the > Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails > from it, send an > email to django-developers+unsubscr...@googlegroups.com > <mailto:django-developers%2bunsubscr...@googlegroups.com>. > To post to this group, send email to > django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at > https://groups.google.com/group/django-developers. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/django-developers/576D6702.3080501%40oddbird.net > . > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the > Google Groups "Django developers (Contributions to Django > itself)" group. > To unsubscribe from this group and stop receiving emails from > it, send an email to > django-developers+unsubscr...@googlegroups.com > <mailto:django-developers%2bunsubscr...@googlegroups.com>. > To post to this group, send email to > django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at > https://groups.google.com/group/django-developers. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/django-developers/CAK8PqJESDrr05-1jJeTbz8UQ%3D%2BJXYHU88w1iGBBnby5czwwVSA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google > Groups "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to django-developers+unsubscr...@googlegroups.com > <mailto:django-developers%2bunsubscr...@googlegroups.com>. > To post to this group, send email to > django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/django-developers/20160624172521.GF12981%40inel.local. > > For more options, visit https://groups.google.com/d/optout. > > > > > -- > > *Tobias McNulty > *Chief Executive Officer > > tob...@caktusgroup.com <mailto:tob...@caktusgroup.com> > www.caktusgroup.com <http://www.caktusgroup.com/> > > -- > You received this message because you are subscribed to the Google > Groups "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to django-developers+unsubscr...@googlegroups.com > <mailto:django-developers+unsubscr...@googlegroups.com>. > To post to this group, send email to django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAMGFDKQGyJPe%2BnNcsjusPZeMEquPGnobdhp_0pjxXEoJrWtqPQ%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAMGFDKQGyJPe%2BnNcsjusPZeMEquPGnobdhp_0pjxXEoJrWtqPQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/576D7260.10407%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
