#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
-------------------------------+------------------------------------
Reporter: Matt Westcott | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Matt Westcott):
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/11010
I encountered another subtle bug along the way (which I suspect has
existed since 1.x): #12879 calls for us to strip duplicates from the input
lists, but in the current implementation the only de-duplication happens
during `Media.merge`, so this never happens in the case of a single list.
I've now extended the tests to cover this:
https://github.com/django/django/pull/11010/files#diff-
7fc04ae9019782c1884a0e97e96eda1eR154 . As a minor side effect of this
extra de-duplication step, tuples get converted to lists more often, so
I've had to fix up some existing tests accordingly - hopefully that's
acceptable fall-out :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/30179#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.1032e82dfdbdd52cf2a562ddd04c0ab5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
