On Mon, 31 Mar 2025, Linus Torvalds <torva...@linux-foundation.org> wrote: > On Mon, 31 Mar 2025 at 03:17, Jani Nikula <jani.nik...@linux.intel.com> wrote: >> >> I suggest a Kconfig knob to truly make this opt-in, only for developers >> who actually want it. > > So honestly, the thing I *really* hated was the horrendous naming. > > I live in auto-complete. I basically never type out file-names, and I > replace keyboards every once in a while because my TAB key has worn > down (not really, but you get the idea). > > And *if* this feature is useful - and while I disagree about the whole > "header files have to be self-sufficient" as a general rule, I can see > it being useful for uapi headers - then dammit, the file naming needs > to *DIE*. It needs to be taken out behind the shed and shot in the > head, because it messes with TAB-completion. > > Having "this has been checked" turds that live in the same name-space > as real files is wrong. > > In the kernel, we often hide them explicitly (ie using the dot prefix > to make them hide, but also to make them not mess with auto-complete). > That's an option. But some people hate the hiding, and if that's an > issue, just put it all in a different subdirectory entirely. > > Yes, I realize that you guys may live in the whole "different > subdirectory entirely" world of doing the whole build in a separate > build directory, and might say "why are you working in the same tree > as the generated files in the first place if auto-complete is so > important to you". > > And to that I say "because I equally often look at the generated > files". When they make *sense* to look at, not when they are > auto-generated makefile checking crap. > > So please. This feature needs to be done completely differently.
I've polished, or, more accurately, hidden the disgusting turds [1]. I hope this is an acceptable approach. I've never claimed this feature is universally useful, certainly not for all of include/linux, but I think it has been more helpful than not in i915 and xe drivers. And now hopefully drm more widely. I wish kbuild had support for it in a way that drivers could opt-in *if* they wanted it, but without copy-pasting the boilerplate. BR, Jani. [1] https://lore.kernel.org/r/20250401121830.21696-1-jani.nik...@intel.com -- Jani Nikula, Intel
