On Tue, 1 Apr 2025 at 05:21, Jani Nikula <jani.nik...@linux.intel.com> wrote:
>
> The header checks have existed for uapi headers before, including the,
> uh, turds, but apparently adding them in drm broke the camel's back.
The uapi header test things never caused any problems for me [*],
because they don't actually pollute the source tree.
Why? Because they all end up in that generated 'usr/include/' directory.
So when I look at the source files, filename completion is entirely
unaffected, and it all works fine.
Look, I can complete something like
include/uapi/asm-generic/poll.h
perfectly fine, because there is *not* some generated turd that affects it all.
Because for the uapi files those hdrtest files end up being in
./usr/include/asm-generic/poll.hdrtest
and I never have any reason to really look at that subdirectory at
all, since it's all generated.
Or put another way - if I _were_ to look at it, it would be exactly
because I want to see some generated file, in which case the 'hdrtest'
turd would be part of it.
(Although I cannot recall that ever having actually happened, to be
honest - but looking at various header files is common, and I hit the
drm case immediately)
Would you mind taking more of that uapi approach than creating that
hidden directory specific to the drm tree? Maybe this could *all* be
generalized?
Linus
[*] I say "never caused any problems for me", but maybe it did way in
the past and it was fixed and I just don't recall. I have definitely
complained about pathname completion issues to people before.
