Re: [PATCH v2 1/5] drm/tyr: Use register! macro for GPU_CONTROL

[Boris Brezillon]

On Wed, 11 Mar 2026 16:03:58 -0700
Deborah Brouwer <deborah.brou...@collabora.com> wrote:

> +        /// Support flags for compressed texture formats. Read only constant.
> +        pub(crate) TEXTURE_FEATURES_0(u32) @ 0xb0 {
> +            31:0    format;

That thing is a bitmap of supported formats, the index in the bitmap is
an opaque format ID.

s/format/supported_formats/

> +        }

How about we define that one as an array from the start:

        pub(crate) TEXTURE_FEATURES(u32)[4] @ 0xb0 {
            31:0    supported_formats;
        }