Improve code readability in vop2_setup_csc_mode() by using enum vop_csc_format for the csc_mode variable, as well as for the return type of the vop2_convert_csc_mode() helper, which already returns CSC_* enumerators.
While at it, replace the nonsensical 'csc_mode = false' assignment in the no-conversion branch with the equivalent CSC_BT601L, which carries the same value (0) but is type-correct. Signed-off-by: Cristian Ciocaltea <[email protected]> --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index df475173dc8e..e0d6e42fedb1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -648,7 +648,7 @@ static void vop2_setup_scale(struct vop2 *vop2, const struct vop2_win *win, } } -static int vop2_convert_csc_mode(int csc_mode) +static enum vop_csc_format vop2_convert_csc_mode(int csc_mode) { switch (csc_mode) { case V4L2_COLORSPACE_SMPTE170M: @@ -711,7 +711,7 @@ static void vop2_setup_csc_mode(struct vop2_video_port *vp, int input_csc = V4L2_COLORSPACE_DEFAULT; int output_csc = vcstate->color_space; bool r2y_en, y2r_en; - int csc_mode; + enum vop_csc_format csc_mode; if (is_input_yuv && !is_output_yuv) { y2r_en = true; @@ -724,7 +724,7 @@ static void vop2_setup_csc_mode(struct vop2_video_port *vp, } else { y2r_en = false; r2y_en = false; - csc_mode = false; + csc_mode = CSC_BT601L; } vop2_win_write(win, VOP2_WIN_Y2R_EN, y2r_en); -- 2.54.0
