On Thu, Mar 11, 2010 at 02:06:02PM +0100, Daniel Vetter wrote: > Hi all, > > This patch pile moves the "static struct radeon_asic <asic>" definitions > form radeon_asic.h into the asic-specific files, where I think they belong. > This way radeon_asic.h becomes a real header file that can be #included. > And indeed, with all the copy&pasting of function declarations, one has > gotten out of sync. > > The next step would be to collect asic specific declarations in > radeon_asic.h - atm they are somewhat scattered. But this can easily be > done on the go and has way too much potential for conflicts with other > patches. So I didn't do this. > > Tested on my rv570. > > Comments higly welcome. > > Yours, Daniel
It all looks good from a quick read through of the patches. For gathering asic function prototype i kind of started adding them to radeon.h at the bottom (there is already a bunch of them). Thus i think radeon_asic.h can be kill and extern declaration directly put into radeon_asic.c Cheers, Jerome > > Daniel Vetter (14): > drm/radoen: move r100 asic struct to r100.c > drm/radoen: move r200 asic struct to r200.c > drm/radeon: move r300 asic structs to r300.c > drm/radeon: move r420 asic struct to r420.c > drm/radoen: move rs400 asic struct to rs400.c > drm/radoen: move rs600 asic struct to rs600.c > drm/radoen: move rs690 asic struct to rs690.c > drm/radoen: move rv515 asic struct to rv515.c > drm/radoen: move r520 asic struct to r520.c > drm/radoen: move r600 asic struct to r600.c > drm/radoen: move rv770 asic struct to rv770.c > drm/radoen: move evergreen asic struct to evergreen.c > drm/radoen: unconfuse return value of radeon_asic->clear_surface_reg > drm/radeon: include radeon_asic.h in <asic>.c > > drivers/gpu/drm/radeon/evergreen.c | 39 +++- > drivers/gpu/drm/radeon/r100.c | 39 +++ > drivers/gpu/drm/radeon/r200.c | 38 +++ > drivers/gpu/drm/radeon/r300.c | 76 ++++++ > drivers/gpu/drm/radeon/r420.c | 39 +++ > drivers/gpu/drm/radeon/r520.c | 39 +++ > drivers/gpu/drm/radeon/r600.c | 43 +++- > drivers/gpu/drm/radeon/radeon.h | 3 +- > drivers/gpu/drm/radeon/radeon_asic.h | 494 > ++-------------------------------- > drivers/gpu/drm/radeon/rs400.c | 39 +++ > drivers/gpu/drm/radeon/rs600.c | 43 +++- > drivers/gpu/drm/radeon/rs690.c | 39 +++ > drivers/gpu/drm/radeon/rv515.c | 41 +++- > drivers/gpu/drm/radeon/rv770.c | 42 +++- > 14 files changed, 518 insertions(+), 496 deletions(-) > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > -- > _______________________________________________ > Dri-devel mailing list > Dri-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dri-devel > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
