On Thu, Mar 11, 2010 at 05:34:28PM +0100, Jerome Glisse wrote: > On Thu, Mar 11, 2010 at 05:24:22PM +0100, Rafał Miłecki wrote: > > 2010/3/11 Alex Deucher <alexdeuc...@gmail.com>: > > > I like keeping all the asic definitions in one file as you tend to > > > need to update them all at one time and having them spread across all > > > the asic files increases the likelihood of one or more of them getting > > > missed. But I can live with it if other folks think it's a good idea. > > > > Same here. One file means easier editing. Maybe we could use some > > other of proposed tricks? > > > > -- > > Rafał > > I don't have strong feeling but Alex has a point, right now we often > update them, maybe we should add radeon_asic.c and move asic init > (function now in radeon_device.c) along structure there.
Ok, convinced. I'll respin the patch series along your idea (creating radeon_asic.c) and resend. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
