On Thu, Mar 11, 2010 at 04:46:01PM +0100, Jerome Glisse wrote: > On Thu, Mar 11, 2010 at 02:06:02PM +0100, Daniel Vetter wrote: > > Hi all, > > > > This patch pile moves the "static struct radeon_asic <asic>" definitions > > form radeon_asic.h into the asic-specific files, where I think they belong. > > This way radeon_asic.h becomes a real header file that can be #included. > > And indeed, with all the copy&pasting of function declarations, one has > > gotten out of sync. > > > > The next step would be to collect asic specific declarations in > > radeon_asic.h - atm they are somewhat scattered. But this can easily be > > done on the go and has way too much potential for conflicts with other > > patches. So I didn't do this. > > > > Tested on my rv570. > > > > Comments higly welcome. > > > > Yours, Daniel > > It all looks good from a quick read through of the patches. For > gathering asic function prototype i kind of started adding them > to radeon.h at the bottom (there is already a bunch of them). Thus > i think radeon_asic.h can be kill and extern declaration directly > put into radeon_asic.c
Yes, I've noticed that radeon.h has started to accumulate some declarations (because radeon_asic.h could not be included, I think). IMHO radeon.h is already growing out of bounds, so my plan was to move these declarations to radeon_asic.h. Most of the functions are only used by the asic specific support code (eg. r600 the blit stuff) so would only pollute the general namespace in radeon.h Does that sound reasonable? btw, radeon_asic.c doesn't exist here in my tree. > Cheers, > Jerome Cheers, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
