Brian Aker wrote: > Hi! > > On Aug 20, 2008, at 7:20 PM, Baron Schwartz wrote: > >> And is the engine asked about the structure of the table, too? > > Yes. > >> I hope so :-) I hope nothing outside the engine is telling the engine >> about itself. > > > I am 90% sure that what should be returned by the ha_discovery is a > table proto buf (which is then fed to a Table() constructor). 10% of me > thinks the engine should build a Table object itself and act as a > factory for them.
I'm not entirely sure about the connection between ha_discovery() and the table engine, but I would opt for the engines working as table factories (including the discovery!) and if there is a need to support a common .frm format or discovery mechanism, then there should be a library and/or a set of helper function for the engine to use. That way, an engine can opt to use the .frm files if they feel like it, while engines that want to do something special can roll it themselves. However, I think that the parsing should be handled by Drizzle and that a table definition description (a.k.a., "parse tree", but I really don't like that term) should be passed to the engine. In general, I prefer narrow interfaces, and allowing the engines to be responsible for the format and discovery and "just" act at table factories is much easier for each involved entity while still maintaining maximum flexibility. Just my few cents, Mats Kindahl > > Cheers, > -Brian > > -- > _______________________________________________________ > Brian "Krow" Aker, brian at tangent.org > Seattle, Washington > http://krow.net/ <-- Me > http://tangent.org/ <-- Software > _______________________________________________________ > You can't grep a dead tree. > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~drizzle-discuss > Post to : [email protected] > Unsubscribe : https://launchpad.net/~drizzle-discuss > More help : https://help.launchpad.net/ListHelp -- Mats Kindahl Lead Software Developer Replication Team MySQL AB, www.mysql.com
begin:vcard fn:Mats Kindahl n:Kindahl;Mats org:Sun Microsystems adr;quoted-printable:;;Tegv=C3=A4gen 3;Storvreta;SE;74334;Sweden email;internet:[EMAIL PROTECTED] title:Lead Replication Software Developer x-mozilla-html:FALSE version:2.1 end:vcard
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
