Brian Aker wrote: > Hi! > > On Aug 21, 2008, at 1:09 AM, Mats Kindahl wrote: > >> I'm not entirely sure about the connection between ha_discovery() and > > Discovery is just the current tie in point. I do not expect it to stay > the same at all. > >> common .frm format or discovery mechanism, then there should be a >> library and/or a set of helper function for the engine to use. That way, >> an engine can opt to use the .frm files if they feel like it, while >> engines that want to do something special can roll it themselves. > > Agreed. This is just a default discovery method in my book. > >> However, I think that the parsing should be handled by Drizzle and that >> a table definition description (a.k.a., "parse tree", but I really don't >> like that term) should be passed to the engine. > > I want an engine to be able to handle/read that definition (and restore > it). For Innodb this is a requirement for its catalog (and for Archive > for portable tables).
I'm not sure I follow what you're saying, but there's quite a lot of work to write a tokenizer and a parser for SQL, even for a small fragment. Allowing Drizzle to do the dirty work and pass some form of pre-digested description saves a lot of work for everyone. Just my few cents, Mats Kindahl > > Cheers, > -Brian > >> >> >> In general, I prefer narrow interfaces, and allowing the engines to be >> responsible for the format and discovery and "just" act at table >> factories is much easier for each involved entity while still >> maintaining maximum flexibility. >> >> Just my few cents, >> Mats Kindahl >> >>> >>> Cheers, >>> -Brian >>> >>> -- >>> _______________________________________________________ >>> Brian "Krow" Aker, brian at tangent.org >>> Seattle, Washington >>> http://krow.net/ <-- Me >>> http://tangent.org/ <-- Software >>> _______________________________________________________ >>> You can't grep a dead tree. >>> >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~drizzle-discuss >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~drizzle-discuss >>> More help : https://help.launchpad.net/ListHelp >> >> >> -- >> Mats Kindahl >> Lead Software Developer >> Replication Team >> MySQL AB, www.mysql.com >> <mats.vcf> > > -- > _______________________________________________________ > Brian "Krow" Aker, brian at tangent.org > Seattle, Washington > http://krow.net/ <-- Me > http://tangent.org/ <-- Software > _______________________________________________________ > You can't grep a dead tree. > > > -- Mats Kindahl Lead Software Developer Replication Team MySQL AB, www.mysql.com
begin:vcard fn:Mats Kindahl n:Kindahl;Mats org:Sun Microsystems adr;quoted-printable:;;Tegv=C3=A4gen 3;Storvreta;SE;74334;Sweden email;internet:[EMAIL PROTECTED] title:Lead Replication Software Developer x-mozilla-html:FALSE version:2.1 end:vcard
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
