Brian Aker wrote:
Hi!

What happens though when it is a class that you then decide to expose for folks extending the server? Do we rename classes then?

Hmmm...namespaces? This is how Google Protobuffers does it. Seems to work fine there. But that's pure C++, not C wrapper stuff like we need to do.

I don't want to have to rename things either, and we could always go ahead and name the files the same as the class which is defined within it. But that would mean a filename convention such as:

drizzled/item/item_string.cc
drizzled/item/item_float.cc

Which I find a bit annoying. But then again, I am not so fervent on this to care one way or the other all that much. Better to just decide on it and move on :)

Personally I prefer to keep naming conventions such that if we change our minds in the future, we don't have to go around renaming everything.

Understood.

Cheers,
    -Brian

On Dec 9, 2008, at 9:22 AM, Jay Pipes wrote:

Right.  If it was included as:

#include "libmemcached/string.h"

I don't believe there would be any conflicts.

This might be bikesheddy stuff, but I'm in favor of not prefixing filenames with "i" or "f" or stuff like that if there is a solution of just using the proper #include directive...

Cheers,

jay

Brian Aker wrote:
On Dec 9, 2008, at 9:08 AM, Jay Pipes wrote:
#include <libmemcached/string.h>
--
_______________________________________________________
Brian "Krow" Aker, brian at tangent.org
Seattle, Washington
http://krow.net/                     <-- Me
http://tangent.org/                <-- Software
_______________________________________________________
You can't grep a dead tree.
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp


--
_______________________________________________________
Brian "Krow" Aker, brian at tangent.org
Seattle, Washington
http://krow.net/                     <-- Me
http://tangent.org/                <-- Software
_______________________________________________________
You can't grep a dead tree.





_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to