[
https://jira.duraspace.org/browse/DS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19268#action_19268
]
Andrea Schweer commented on DS-690:
-----------------------------------
I've incorporated your patch into my stats customisations and have given it a
bit of testing with viewing statistics. So far it looks good to me, though I do
wonder about your non-stats redirect. You're only doing the non-stats redirect
for items, but not for collections/communities etc. Is there a reason for that?
Why don't you just make the generic redirect work the same way that the stats
redirect does -- before the long if statement that acts on specific types. Then
you could throw in a 'return' at the end of the redirect and wouldn't have to
make any further changes to when the usage event gets fired etc.
I also wonder whether you need the redirect to the named dispatcher. My custom
stats use slightly different URLs but they work really well even with the
generic redirect if I inject the handle into the request there. It feels a bit
bad to hardcode the statistics URL path in the handle servlet.
I'll attach my current version of HandleServlet.java; this was 1.6.2 before my
modifications.
> Tidy up URL mapping for DisplayStatisticsServlet (JSPUI servlet that handles
> solr statistics)
> ---------------------------------------------------------------------------------------------
>
> Key: DS-690
> URL: https://jira.duraspace.org/browse/DS-690
> Project: DSpace
> Issue Type: Improvement
> Components: JSPUI
> Reporter: Kim Shepherd
> Assignee: Kim Shepherd
> Fix For: 1.8.0
>
> Attachments: Patch_for_DS-690.patch
>
>
> The XMLUI URL mapping for solr statistics is nice and tidy, eg.
> ${contextPath}/handle/123456789/1/statistics
> Whereas the JSPUI URL mapping is not as nice to look at, nor is it as
> functional:
> ${contextPath}/displaystats?handle=123456789/1
> It would help with crawler/sitemap maintenance, path-based authZ, DSO
> resolution, etc. if it was in line with the XMLUI version. My fault. (Mark
> did point this out to me at one stage, too..)
> I'd like to submit a patch for this in time for 1.7, but I wonder whether
> there could be some fallout with researchers, admins, users who have already
> bookmarked older stats pages -- either way, it's better to get the change in
> earlier then later, but I should also make a note in the documentation and
> maybe advertise the change in mailing lists ahead of time.
> I'll put 1.7.0 as a fix version and will work on a patch, but will wait for
> IRC vote/comments before committing code or resolving this issue.
> Cheers,
> Kim
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
