[ 
https://jira.duraspace.org/browse/DS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19299#action_19299
 ] 

Andrea Schweer commented on DS-690:
-----------------------------------

I don't think forwarding to invalid dispatchers is a problem -- they should 
just return 404, which I think they do already, and crawlers are smart enough 
to deal with those.

I don't see a problem with setting the handle attribute (but did pause a for a 
moment and wonder whether it's a good idea).

I hadn't realised the statistics vs displaystats thing -- as I said my 
customisations use different URLs anyway. My personal opinion is to rename the 
legacy statistics reports, but I'm sure this would upset some people. In my 
case we know that some of the repos will want to go from JSPUI to XMLUI in a 
while, so URL parity for my customised stats is a must.

> Tidy up URL mapping for DisplayStatisticsServlet (JSPUI servlet that handles 
> solr statistics)
> ---------------------------------------------------------------------------------------------
>
>                 Key: DS-690
>                 URL: https://jira.duraspace.org/browse/DS-690
>             Project: DSpace
>          Issue Type: Improvement
>          Components: JSPUI
>            Reporter: Kim Shepherd
>            Assignee: Kim Shepherd
>             Fix For: 1.8.0
>
>         Attachments: HandleServlet.java, Patch_for_DS-690.patch
>
>
> The XMLUI URL mapping for solr statistics is nice and tidy, eg.
> ${contextPath}/handle/123456789/1/statistics
> Whereas the JSPUI URL mapping is not as nice to look at, nor is it as 
> functional:
> ${contextPath}/displaystats?handle=123456789/1
> It would help with crawler/sitemap maintenance, path-based authZ, DSO 
> resolution, etc. if it was in line with the XMLUI version. My fault. (Mark 
> did point this out to me at one stage, too..)
> I'd like to submit a patch for this in time for 1.7, but I wonder whether 
> there could be some fallout with researchers, admins, users who have already 
> bookmarked older stats pages -- either way, it's better to get the change in 
> earlier then later, but I should also make a note in the documentation and 
> maybe advertise the change in mailing lists ahead of time.
> I'll put 1.7.0 as a fix version and will work on a patch, but will wait for 
> IRC vote/comments before committing code or resolving this issue.
> Cheers,
> Kim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to