[
https://jira.duraspace.org/browse/DS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19298#action_19298
]
Kim Shepherd commented on DS-690:
---------------------------------
OK, I've tested this a bit further... it works brilliantly and is much tidier
in the forwarder logic. The only catch is the conflict between "statistics" and
"statistics", which is the reason this whole task got complicated to begin with
;-).
Perhaps I'm making things too hard on us by *not* renaming the old stats
reports to something else, like 'site-statistics'. Would that really upset
anyone too much? What do you think:?
Another note: both our patches are susceptible to this "exists but shouldn't
really be valid" dispatcher problem, meaning URLs like this work:
eg. http://dspace.example.com/jspui/handle/123456789/1/mydspace
Before I committed my patch, this would only work on containers, but it'll work
for items now as well, which could mean a whole new bunch of invalid URLs being
cached as 'good' by crawlers.
We also setAttribute (handle) without caring if the servlet we forward to
needs/wants this attribute set, but I don't see that as a real problem.. .we
are working specifically on DSOs with handles, right?
So, I guess we need opinions/votes on the following:
- Clean HandleServlet code and rename URL mappings, or clumsy HandleServlet and
maintain UI parity / both URL mappings?
- If rename URL mappings, rename legacy /statistics reports, or new solr
/statistics (displaystats) reports? (reminder: XMLUI uses /statistics for both
so we break parity either way)
> Tidy up URL mapping for DisplayStatisticsServlet (JSPUI servlet that handles
> solr statistics)
> ---------------------------------------------------------------------------------------------
>
> Key: DS-690
> URL: https://jira.duraspace.org/browse/DS-690
> Project: DSpace
> Issue Type: Improvement
> Components: JSPUI
> Reporter: Kim Shepherd
> Assignee: Kim Shepherd
> Fix For: 1.8.0
>
> Attachments: HandleServlet.java, Patch_for_DS-690.patch
>
>
> The XMLUI URL mapping for solr statistics is nice and tidy, eg.
> ${contextPath}/handle/123456789/1/statistics
> Whereas the JSPUI URL mapping is not as nice to look at, nor is it as
> functional:
> ${contextPath}/displaystats?handle=123456789/1
> It would help with crawler/sitemap maintenance, path-based authZ, DSO
> resolution, etc. if it was in line with the XMLUI version. My fault. (Mark
> did point this out to me at one stage, too..)
> I'd like to submit a patch for this in time for 1.7, but I wonder whether
> there could be some fallout with researchers, admins, users who have already
> bookmarked older stats pages -- either way, it's better to get the change in
> earlier then later, but I should also make a note in the documentation and
> maybe advertise the change in mailing lists ahead of time.
> I'll put 1.7.0 as a fix version and will work on a patch, but will wait for
> IRC vote/comments before committing code or resolving this issue.
> Cheers,
> Kim
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
