[ 
https://jira.duraspace.org/browse/DS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19702#action_19702
 ] 

Andrea Schweer commented on DS-690:
-----------------------------------

Actually, my patch breaks per-collection and per-community browse and most 
likely some other things. Apparently at least per-collection and per-community 
browse rely on extra attributes that are only set within the distinction by 
type. I'm currently fixing this locally; I'll provide an updated patch when I'm 
done.

> Tidy up URL mapping for DisplayStatisticsServlet (JSPUI servlet that handles 
> solr statistics)
> ---------------------------------------------------------------------------------------------
>
>                 Key: DS-690
>                 URL: https://jira.duraspace.org/browse/DS-690
>             Project: DSpace
>          Issue Type: Improvement
>          Components: JSPUI
>            Reporter: Kim Shepherd
>            Assignee: Kim Shepherd
>             Fix For: 1.8.0
>
>         Attachments: HandleServlet.java, Patch_for_DS-690.patch
>
>
> The XMLUI URL mapping for solr statistics is nice and tidy, eg.
> ${contextPath}/handle/123456789/1/statistics
> Whereas the JSPUI URL mapping is not as nice to look at, nor is it as 
> functional:
> ${contextPath}/displaystats?handle=123456789/1
> It would help with crawler/sitemap maintenance, path-based authZ, DSO 
> resolution, etc. if it was in line with the XMLUI version. My fault. (Mark 
> did point this out to me at one stage, too..)
> I'd like to submit a patch for this in time for 1.7, but I wonder whether 
> there could be some fallout with researchers, admins, users who have already 
> bookmarked older stats pages -- either way, it's better to get the change in 
> earlier then later, but I should also make a note in the documentation and 
> maybe advertise the change in mailing lists ahead of time.
> I'll put 1.7.0 as a fix version and will work on a patch, but will wait for 
> IRC vote/comments before committing code or resolving this issue.
> Cheers,
> Kim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to