Hi, > > For C++ "stdint.h" only define this macro if "__STDC_CONSTANT_MACROS" is > > defined, because the ISO C99 standard specifies that.
Yes, this is the standard-conforming way of demanding the namespace pollution :-). For me, it wasn't sufficient however, I also needed ""__STDC_LIMIT_MACROS" at some stage. > We shouldn't pollute the build system with it, then. It belongs in a > special header file that is always included before any other headers. In > the absence of an autoconf-style config.h, src/port.h is the most likely > candidate for that kind of stuff (also for _GNU_SOURCE and similar > macros that are always defined). Even though changing the build system for this is not very nice (thanks a lot for adding my patch by the way!), adding this to sth like port.h is worse IMHO. You would have to include port.h really before any other file (including _all_ standard headers). If one day you decide to import a new ffmpeg (or any other third party library), you would have to change every single ffmpeg include file to have #include "port.h" in front.. I think that would really lead to a compiler option "-include src/port.h" and that would mean changing the build system again. Regards, Wolfram. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ DVBCUT-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dvbcut-user
