H! Wolfram Gloger wrote: [...] >>We shouldn't pollute the build system with it, then. It belongs in a >>special header file that is always included before any other headers. In >>the absence of an autoconf-style config.h, src/port.h is the most likely >>candidate for that kind of stuff (also for _GNU_SOURCE and similar >>macros that are always defined). > > > Even though changing the build system for this is not very nice > (thanks a lot for adding my patch by the way!), adding this to sth > like port.h is worse IMHO. You would have to include port.h really > before any other file (including _all_ standard headers).
Alternatively, use a single header that defines the macros and then includes all standard headers. > If one day > you decide to import a new ffmpeg (or any other third party library), > you would have to change every single ffmpeg include file to have > #include "port.h" in front.. We don't need to modify ffmpeg. The macro must be defined when *dvbcut* is compiled, thanks to bad interface design. > I think that would really lead to a compiler option "-include > src/port.h" and that would mean changing the build system again. That option is gcc specific, AFAIK. Not an option (pun intended ;) for applications like dvbcut. Maybe someone wants to use another compiler. -- Michael "Tired" Riepe <[EMAIL PROTECTED]> X-Tired: Each morning I get up I die a little ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ DVBCUT-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dvbcut-user
