On Tue, 2013-05-21 at 11:21 +0300, Or Gerlitz wrote: > On Tue, May 21, 2013 at 10:06 AM, Eilon Greenstein <eil...@broadcom.com> > wrote: > > Or - at least for the bnx2x, it is easy to add support for this new ndo. > > Do you understand what's the equivalent of that mysterious module > param for your driver/HW - or you just copied and pasted that black > magic code? >
The module parameter is not the interesting part of this patch. It is clear that unloading the module while this sort of traffic is running is not safe and the alternative of adding a reference count or something similar sounds too costly (after all, this patch is about performance). I just played with it to get a feel of the latency improvement - I did not try unloading the module during traffic so I do not care about the module parameter part right now. I agree that the unload should be looked into - but the general concept is great and it is a very nice improvement. ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
