On 09/24/15 12:01, Bruce Cran wrote: > On 9/24/15 1:38 AM, Laszlo Ersek wrote: > >> I can promise right now that I *will not* use Gerrit, or any other >> web-based tool, to review or otherwise handle patches. Sorry. >> >> Othes are welcome to do so, of course, but I only work with patches via >> email and git fetch / git push. I'll only see others' reviews made in a >> web-based tool if that tool posts the reviews (in a reasonable message >> format) to the list. > > So you wouldn't even use a command-line interface to a web-based tool > that has commands to manage patches? For example "cr list" to show > outstanding reviews, and "cr land" to push a review that has been > approved to source control.
Of course not. First, I don't see why I should change my workflow (including CLI tools I use interactively) that I've been using for almost five years now. I'm using the most basic, most widely available tools: "raw" git commands, and email. Second, for me the patches must not *live* in a web application. I.e. a web application must not be the primary component / master / database that stores and manages patches. Looking at large, distributed open source projects, like Linux and QEMU, patches percolate from submitter to the central repo & branch via maintainer trees. We're definitely not at this level of patch traffic on edk2-devel. Maybe an explosion in contributors will happen at some point, maybe not. Until it happens, I'm just fine tracking and reviewing patches on the list, and (if necessary) fetching them from contributor trees. If / when it does happen, and we'll need a hierarchy of maintainers (delineated by functional components, subsystems or whatever), we should switch to maintainer trees and pull requests, just like Linux and QEMU does. If Jordan is willing to work with the tools you mentioned above, that's his prerogative :) If email and "raw" git can coexist -- as first class citizens with 100% functionality -- with any web-based app, to be introduced later, then I'll be fine. Otherwise, I'll fight it, and if I lose, I'll leave. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
