On 02/18/16 13:14, Laszlo Ersek wrote: > Okay, I'm done ranting. > > Reviewed-by: Laszlo Ersek <[email protected]>
So let me review how my comments have worked out for this posting. First I nacked it, because I thought the fact was not sufficiently appreciated that David had posted a conflicting / more comprehensive / potentially more correct patch series. Then I withdrew my NACK, after David said he was okay with this patch going in first -- assuming it was correct. Then I gave my R-b to this patch, admitting that I couldn't verify the edk2-only customizations against the 1.0.2f release. Turns out those customizations are indeed no longer correct, so my R-b was in error. Not exactly a spotless track record for me, in this thread. I think I shall stay away from reviewing OpenSSL updates. In parallel, I propose that David be added to the CryptoPkg maintainers in "Maintainers.txt" (provided he wants it). Then he should get automatically CC'd on such rebases. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
