On 07/01/16 03:10, Laszlo Ersek wrote:
> +STATIC CONST RESOURCE_PADDING mPadding = {
> + //
> + // MmioPadding
> + //
> + {
> + ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc
> + (UINT16)( // Len
> + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) -
> + OFFSET_OF (
> + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR,
> + ResType
> + )
> + ),
> + ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType
> + 0, // GenFlag:
> + // ignored
> + 0, // SpecificFlag:
> + // non-prefetchable
> + 64, // AddrSpaceGranularity:
> + // reserve 64-bit aperture
> + 0, // AddrRangeMin:
> + // ignored
> + SIZE_2MB, // AddrRangeMax:
> + // align at 2MB
This
> + 0, // AddrTranslationOffset:
> + // ignored
> + SIZE_2MB // AddrLen:
> + // 2MB padding
> + },
> +
> + //
> + // IoPadding
> + //
> + {
> + ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc
> + (UINT16)( // Len
> + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) -
> + OFFSET_OF (
> + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR,
> + ResType
> + )
> + ),
> + ACPI_ADDRESS_SPACE_TYPE_IO,// ResType
> + 0, // GenFlag:
> + // ignored
> + 0, // SpecificFlag:
> + // ignored
> + 0, // AddrSpaceGranularity:
> + // ignored
> + 0, // AddrRangeMin:
> + // ignored
> + 512, // AddrRangeMax:
> + // align at 512 IO ports
and this are incorrect. I missed in Table 8 that these values must be 2^n-1.
I'll update this for v2, but I'll wait for some comments first.
Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
